Add a [ufl] install option to install Basix and UFL#696
Closed
Add a [ufl] install option to install Basix and UFL#696
Conversation
garth-wells
reviewed
Sep 18, 2023
Member
garth-wells
left a comment
garth-wells
left a comment
There was a problem hiding this comment.
This will another line that we'll need to update at each release - is it worth it?
Member
Author
I'm not sure. Currently, just installing it with optional is fine I guess as that only has numba on top of ufl. Maybe worth revisiting in future if we ever add a lot more stuff to optional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
basix.uflis an intended way to create UFL elements, it might be useful to be able to runpip install git+http://github.com/FEniCS/basix[ufl]to install UFL with Basix.